Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize f(*args, **kwds) function argument "parsing" #1661

Merged
merged 1 commit into from
Jun 6, 2021
Merged

Optimize f(*args, **kwds) function argument "parsing" #1661

merged 1 commit into from
Jun 6, 2021

Conversation

birkenfeld
Copy link
Member

by using the VARARGS convention and not parsing anything.

Based on #1660.

Benchmark result:

before

---------------------------------------------------------------------------------------------- benchmark: 8 tests ---------------------------------------------------------------------------------------------
Name (time in ns)                Min                    Max                  Mean              StdDev                Median                IQR             Outliers  OPS (Kops/s)            Rounds  Iterations
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_args_and_kwargs_py     541.0999 (5.50)      1,644.1001 (6.12)       584.9937 (5.36)      36.0946 (4.95)       588.0007 (5.35)     23.1012 (3.61)     5401;4727    1,709.4200 (0.19)     150603          10
test_args_and_kwargs        919.9866 (9.35)      7,811.0024 (29.07)    1,011.1348 (9.26)     121.0042 (16.61)    1,009.9902 (9.20)     58.9935 (9.22)     4374;4426      988.9878 (0.11)     130532           1
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

after

---------------------------------------------------------------------------------------------- benchmark: 8 tests ---------------------------------------------------------------------------------------------
Name (time in ns)                Min                    Max                  Mean              StdDev                Median                IQR             Outliers  OPS (Kops/s)            Rounds  Iterations
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
test_args_and_kwargs        258.0004 (2.61)     11,361.5504 (43.15)      283.3001 (2.62)      69.7288 (9.09)       282.9998 (2.64)     15.4498 (2.38)     1571;9116    3,529.8262 (0.38)     176026          20
test_args_and_kwargs_py     536.9991 (5.44)     15,384.3997 (58.42)      590.1359 (5.46)      93.3103 (12.16)      589.0994 (5.49)     26.9996 (4.15)     6864;7489    1,694.5248 (0.18)     148810          10
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------

davidhewitt
davidhewitt approved these changes Jun 5, 2021
View reviewed changes
Copy link
Member

@davidhewitt davidhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, we knew this was going to be fast but a ~ 75% reduction is just awesome 🏎️

It looks like I've merged some conflicts at the same time (sorry) - if you'd like I can rebase this and #1660 and merge them in? Or if you're happy to do it that's also fine!

@birkenfeld
Copy link
Member Author

Rebased - will merge once CI is done.

@birkenfeld
Argument parsing: optimize the f(*args, **kwds) case.
bd6788b 
Use the VARARGS calling convention and just pass through the two objects.
@birkenfeld birkenfeld merged commit c57afeb into main Jun 6, 2021
@birkenfeld birkenfeld deleted the optimize_forwarding branch June 6, 2021 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidhewitt davidhewitt davidhewitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@birkenfeld @davidhewitt